Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-js-css target should modify .~build/ files and not the working directory #81

Closed
raamdev opened this issue Apr 11, 2016 · 3 comments
Closed
Assignees

Comments

@raamdev
Copy link
Contributor

raamdev commented Apr 11, 2016

Forking from #68 (comment).

The new -js-css target currently modifies files in the repo. It should only modify files in .~build/ (see discussion).

However, we can't change it to modify files in .~build/ until we modify the rest of the build system to allow for sourcing the packages from .~build/. (Currently packaging happens before .~build/ is populated and the distributable packages are sourced from the repo directory, not the .~build/ directory.)

This work will be related to #80.

@jaswrks
Copy link
Contributor

jaswrks commented Apr 11, 2016

Thanks for opening this. I began some work on this over the weekend so I now need to pull together some of the recent changes you've added to that and then open a PR for your review. I worked to better organize the targets and there are a few changes throughout that make this possible.

@jaswrks jaswrks self-assigned this Apr 11, 2016
jaswrks pushed a commit that referenced this issue Apr 14, 2016
@jaswrks
Copy link
Contributor

jaswrks commented Apr 14, 2016

This will be corrected by: #83

@jaswrks
Copy link
Contributor

jaswrks commented Apr 16, 2016

@jaswrks jaswrks closed this as completed Apr 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants