You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Testing Phings v160418 against the dev branch of Comet Cache Pro, I found that running phing build-all or phing full-build-all does not change the Plugin Name: token at the top of the main Lite plugin file:
<?php
/*
Version: 160510
Text Domain: comet-cache
Plugin Name: Comet Cache Pro
Network: true
Author: WebSharks, Inc.
Author URI: http://websharks-inc.com/
Notice how it still says Comet Cache Pro, when it should just say Comet Cache (this is the Lite version).
This bug is caused by this line, which describes only ${project_slug}.php, when what we also need is ${project_lite_slug}.php. It doesn't make sense to add the Lite slug to _wp_token_pattern_set, since it may not be applicable in every context (and PatternSet does not support If/Then), so I suggest we simply add an include after this line:
<include pattern="${project_lite_slug}.php" />
I have confirmed the above fixes the problem.
The text was updated successfully, but these errors were encountered:
Testing Phings v160418 against the dev branch of Comet Cache Pro, I found that running
phing build-all
orphing full-build-all
does not change thePlugin Name:
token at the top of the main Lite plugin file:.~build/comet-cache/.~build/comet-cache/comet-cache.php
Notice how it still says
Comet Cache Pro
, when it should just sayComet Cache
(this is the Lite version).This bug is caused by this line, which describes only
${project_slug}.php
, when what we also need is${project_lite_slug}.php
. It doesn't make sense to add the Lite slug to_wp_token_pattern_set
, since it may not be applicable in every context (and PatternSet does not support If/Then), so I suggest we simply add an include after this line:I have confirmed the above fixes the problem.
The text was updated successfully, but these errors were encountered: