Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lite generation does not change Plugin Name token #95

Closed
raamdev opened this issue May 10, 2016 · 1 comment
Closed

Lite generation does not change Plugin Name token #95

raamdev opened this issue May 10, 2016 · 1 comment
Labels

Comments

@raamdev
Copy link
Contributor

raamdev commented May 10, 2016

Testing Phings v160418 against the dev branch of Comet Cache Pro, I found that running phing build-all or phing full-build-all does not change the Plugin Name: token at the top of the main Lite plugin file:

.~build/comet-cache/.~build/comet-cache/comet-cache.php

<?php
/*
Version: 160510
Text Domain: comet-cache
Plugin Name: Comet Cache Pro
Network: true

Author: WebSharks, Inc.
Author URI: http://websharks-inc.com/

Notice how it still says Comet Cache Pro, when it should just say Comet Cache (this is the Lite version).


This bug is caused by this line, which describes only ${project_slug}.php, when what we also need is ${project_lite_slug}.php. It doesn't make sense to add the Lite slug to _wp_token_pattern_set, since it may not be applicable in every context (and PatternSet does not support If/Then), so I suggest we simply add an include after this line:

<include pattern="${project_lite_slug}.php" />

I have confirmed the above fixes the problem.

@raamdev raamdev added the bug label May 10, 2016
@raamdev raamdev changed the title Lite generation does not change Plugin Name: token Lite generation does not change Plugin Name token May 10, 2016
@jaswrks
Copy link
Contributor

jaswrks commented May 10, 2016

Next Release Changelog:

@jaswrks jaswrks closed this as completed May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants