Feature/Refactor #125
Merged
Feature/Refactor #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…domain` - **IMPORTANT:** New required `.build.props` property for lite variation: `project_lite_text_domain` - If you are missing either of these new properties Phing will fail validation and you will be warned that a property is missing. - **IMPORTANT:** As noted below, many of the pattern sets were updated in this release. Please review your next build carefully in case there are any new bugs. In particular, please be sure to review the files that make it into the final ZIP distro, as well as the final Lite repo at GitHub. I don't believe there are any problems, but given the number of changes to the pattern sets in this release, it would be worth your while to do a quick review just to be sure. - **New Wiki Article:** https://github.com/websharks/phings/wiki/Build-Flags-&-Props - Reorganized all pattern sets. Now using a layered approach that is based on our `.gitignore` and `.gitattributes` file for better consistency and easier maintenance. - Adding `defaultExcludes="false"` to all `<fileSet>` tags now that there is a more comprehensive approach being taken with exclusions (i.e., pattern sets were drastically improved in this release). - Changing `-X` argument on `zip` command to the long name for improved clarity; i.e., `--no-extra`. - Refactor: `_is_wp_core_framework_project` now `_is_core_project`. - Refactor: `_is_lite_build` now `_doing_lite_build`. - Refactor: `_has_lite_build_props` now `_has_lite_variation`. - Adding GitHub credential validator. Now required to finish a release. - Adding Slack credential validator. Now required to finish a release or update bleeding edge. - Correcting indentation in all files; i.e., no need to indent inside `<?xml>` tag.
added 10 commits
June 26, 2016 09:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.