Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change info after setup to edit /ets/hosts #130

Merged
merged 2 commits into from Oct 30, 2018

Conversation

dmajkic
Copy link
Contributor

@dmajkic dmajkic commented Jun 14, 2018

Requirements

Description of the Change

/etc/hosts exist on both Linux and on macOS, where /etc is symlinked to /private/etc

Alternate Designs

/private/etc/hosts does not exist on Linux

Benefits

Right thing to suggest to Linux developer

Possible Drawbacks

None - it is an info message change

Verification Process

Installed on Ubuntu. Setup instructed to edit /private/etc/hosts which is not the right location

Applicable Issues

None.

/etc/hosts exist on both Linux and on macOS, where /etc is symlinked to /private/etc
@coveralls
Copy link

Pull Request Test Coverage Report for Build 574

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.7%) to 98.315%

Files with Coverage Reduction New Missed Lines %
cmd/phpcs-server/main.go 17 94.06%
Totals Coverage Status
Change from base Build 573: -1.7%
Covered Lines: 992
Relevant Lines: 1009

💛 - Coveralls

@valendesigns valendesigns merged commit 713dfed into wptide:develop Oct 30, 2018
@jeffpaul jeffpaul added this to the 1.0.0-beta2 milestone Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants