Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctness: Punctuation #202

Merged
merged 2 commits into from May 12, 2020
Merged

Correctness: Punctuation #202

merged 2 commits into from May 12, 2020

Conversation

pmbaldha
Copy link
Contributor

It appears that you have an unnecessary comma before the dependent clause marker.

@coveralls
Copy link

coveralls commented Feb 22, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 4588631 on pmbaldha:patch-1 into 7cf67f7 on wptide:develop.

Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I suppose this is more correct grammar. Generally though its most helpful to fix larger meaningful errors than minor grammar changes. The time it takes others to review minor items is not as helpful than everyone working towards solving larger issues, so please keep that in mind for future PRs... thanks!

@jeffpaul jeffpaul added this to the 1.0.0 milestone May 12, 2020
@jeffpaul jeffpaul merged commit 24ecc5d into wptide:develop May 12, 2020
@jeffpaul jeffpaul added this to To Do in PHP Compat on WordPress.org via automation Jun 23, 2020
@jeffpaul jeffpaul moved this from To Do to Done in PHP Compat on WordPress.org Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants