Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Sniff] Check for wp-load.php #44

Open
justintadlock opened this issue Aug 12, 2016 · 5 comments
Open

[New Sniff] Check for wp-load.php #44

justintadlock opened this issue Aug 12, 2016 · 5 comments

Comments

@justintadlock
Copy link

Otto brought this up in Slack (https://wordpress.slack.com/archives/themereview/p1470952005002504), but it's long been one of those things that we wouldn't allow.

Basically, themes should not be attempting to find and load the wp-load.php file. I can't think for a legit use case for themes to do this.

This is most often an issue when themes are attempting to create a dynamic stylesheet instead of utilizing the wp_add_inline_style() function.

@Pross
Copy link

Pross commented Aug 12, 2016

Looking for wp-load or blog-header is one check maybe look for ../ too? If you use the dir functions properly you should never need it

@khacoder
Copy link
Contributor

Cool, I was thinking of adding a sniff when I saw Otto made the comment.

@grappler
Copy link
Member

Making a note that @dmtrmrv is working a sniff.

@dmtrmrv
Copy link

dmtrmrv commented Dec 10, 2016

Yes, I am. Will publish add a PR shortly.

@dingo-d
Copy link
Member

dingo-d commented May 18, 2019

@dmtrmrv I know it's been a long time but are you interested in picking this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants