Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No wordpress.org allowed in Theme URI #51

Open
5 tasks
khacoder opened this issue Aug 12, 2016 · 4 comments
Open
5 tasks

No wordpress.org allowed in Theme URI #51

khacoder opened this issue Aug 12, 2016 · 4 comments

Comments

@khacoder
Copy link
Contributor

khacoder commented Aug 12, 2016

[New sniff] No wordpress.org allowed in Theme URI

Rule type:

Error

Rule:

ERROR | Verify - in style.css that the Theme URI does not point to wordpress.org (with predefined list of themes which are exempt and live under the wordpressdotorg user or have a check based on Author name.

Rule as it is found in the handbook.
There is no specific rule on this.

Theme check file covering this rule:

https://github.com/Otto42/theme-check/blob/master/checks/uri.php

Decision needed:

If we are striving to have rules for sniffs the following rule should be considered.
Selling, credits, and links

  • Using a WordPress.org Theme URI is reserved for official themes.
Notes for implementation:
  • This sniff will rely on the WordPress_AbstractThemeSniff Class to get the $sniff_helper array.
  • Testing will require that a style.css file is in the same folder as the test file.

To do:

  • Decision and implementation to add the rule in the Theme Review handbook to the Requirements page.
  • Create unit tests
  • Create new sniff
  • Adjust existing WPCS / PHPCS sniff and send in PR upstream.
  • Add existing sniffname sniff to the ruleset.
@khacoder khacoder self-assigned this Aug 12, 2016
@khacoder khacoder changed the title No wordpress.org allowed in Theme or Author URI No wordpress.org allowed in Theme Aug 12, 2016
@khacoder khacoder changed the title No wordpress.org allowed in Theme No wordpress.org allowed in Theme URI Aug 12, 2016
@khacoder
Copy link
Contributor Author

I have this sniff ready to go, however it uses the $sniff_helper array from the proposed WordPress_AbstractThemeSniff class.

@khacoder khacoder removed their assignment Sep 29, 2016
@grappler
Copy link
Member

grappler commented Dec 3, 2016

PR #60

@carolinan
Copy link

Can we add underscores.me as well? It would block some placeholders.

@dingo-d
Copy link
Member

dingo-d commented May 18, 2019

Is this covered in Theme Sniffer @timelsass ? I have the strangest feeling it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants