New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates to the codebase #56

Merged

wpumacay merged 4 commits into main from dev

Dec 23, 2023

Owner

wpumacay commented Dec 22, 2023

This PR updates some minor options of the codebase

Usage of [[nodiscard]] as we're using c++17
Remove a warning related to the FindPython module in pybind11
remove linter warnings
Add ubuntu 20.04 as extra check in the ci workflow (check with older compilers)

wpumacay added 4 commits

December 22, 2023 18:20


          (Chore): removing linter warnings

13c8038


          (chore): hint pybind11 to use FindPython

04fea8b


          (Chore): use [[nodiscard]] for toString methods

2c37ee3


          (CI|CD): add ubuntu 20.04 for ci-linux workflow

4994cde

wpumacay self-assigned this

wpumacay merged commit 50788af into main

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment