A bunch of small cleanups, mostly to get tests passing. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thesis in its arg list.
| @@ -61,7 +61,7 @@ describe Resque::Plugins::ConcurrentRestriction do | |||
|
|
|||
| it "should encode jobs correctly" do | |||
| job = Resque::Job.new("somequeue", {"class" => "RestrictionJob", "args" => [1, 2, 3]}) | |||
| ConcurrentRestrictionJob.encode(job).should == '{"queue":"somequeue","payload":{"class":"RestrictionJob","args":[1,2,3]}}' | |||
| JSON.parse(ConcurrentRestrictionJob.encode(job)).should == JSON.parse('{"queue":"somequeue","payload":{"class":"RestrictionJob","args":[1,2,3]}}') | |||
There was a problem hiding this comment.
Why was this needed? Tests are passing for me. Is it a 1.8/1.9 difference with ordered hashes or something?
There was a problem hiding this comment.
Yes. And while I didn't run through other rubies, I've noticed in the past that rbx and jruby may order differently too. They're consistent in how they do it, but it may not match other rubies.
wr0ngway
pushed a commit
that referenced
this pull request
Oct 21, 2011
A bunch of small cleanups, mostly to get tests passing.
russCloak
added a commit
that referenced
this pull request
Apr 1, 2016
Swap Resque::Helpers for ActiveSupport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.