Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: update versioning/release #265

Merged
merged 3 commits into from Apr 6, 2018

Conversation

kmuehlbauer
Copy link
Member

resolves #263

With these changes the git_revision will be build from the git describe command:

X.Y.Z-N-g0123456

  • X.Y.Z - latest git tag
  • N - commits since latest tag
  • g0123456 - short git hash

With N = 0 we have a tagged release, with N > 0 we have devel. In the version.py is written:

  • short_version - X.Y.Z
  • version - X.Y.Z or X.Y.Z-N-g0123456 (depending on release or not)
  • full_version - X.Y.Z-N-g0123456
  • git_revision - long git hash
  • release - True or False

If the the source is no git-repo and the version.py is missing, then pre-defined values ('unknown') are written to version.py.

Overall this has two benefits:

  1. We have a more meaningful full_version as described above
  2. No need to set ISRELEASED before and after cutting release

@codecov
Copy link

codecov bot commented Apr 6, 2018

Codecov Report

Merging #265 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files          30       30           
  Lines        4517     4517           
=======================================
  Hits         4135     4135           
  Misses        382      382
Flag Coverage Δ
#wradlibtests 91.54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5577d6...13259f1. Read the comment docs.

@kmuehlbauer kmuehlbauer merged commit 81819a6 into wradlib:master Apr 6, 2018
@kmuehlbauer kmuehlbauer deleted the update-versioning branch April 6, 2018 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wradlib versioning scheme
2 participants