Fix cross_section_ppi in util.py for wradlib 2.0 #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed cross_section_ppi function to work with wradlib 2.0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
+ Coverage 86.51% 87.12% +0.60%
==========================================
Files 56 56
Lines 9515 9536 +21
==========================================
+ Hits 8232 8308 +76
+ Misses 1283 1228 -55
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kmuehlbauer
reviewed
Oct 24, 2023
kmuehlbauer
reviewed
Oct 24, 2023
|
@JulianGiles Just one minor thing, otherwise LGTM! Thanks! |
|
@JulianGiles Sorry, I forgot, you might add an entry to https://github.com/wradlib/wradlib/blob/main/docs/release_notes.md. |
|
Sorry for the delay @JulianGiles. Thanks for taking care. |
kmuehlbauer
pushed a commit
that referenced
this pull request
Nov 3, 2023
(cherry picked from commit 042fd73) Signed-off-by: Kai Muehlbauer <kmuehlbauer@wradlib.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed cross_section_ppi to work with wradlib 2.0