Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid hex chars #48

Closed
wants to merge 5 commits into from
Closed

Conversation

xtonik
Copy link
Contributor

@xtonik xtonik commented Jun 7, 2023

Added missing check for digit characters being equal to '0' or greater. As the used way of tightly coupled SWAR testing of character being is around byte range, some character from upper half of ASCII were considered as valid also not filter by existing checks and thus check for characters being less or equal to '9' added also.

There may be better way - smaller number of operations - for testing hexadecimal characters after this change.

There were some troubles with little / big endian integer encoding, it should be verified whether they do not occur on other platform than tested - Intel.

@wrandelshofer
Copy link
Owner

Thank you very much for providing a fix for this issue. 😀
Based on your merge request, I have now commited a fix that uses one operation less. I made multiple commits to the main branch. The most significand was probably this one: a67caba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants