Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richer context for rendering #18

Merged
merged 6 commits into from Feb 2, 2016
Merged

Richer context for rendering #18

merged 6 commits into from Feb 2, 2016

Conversation

imposeren
Copy link
Contributor

This will allow to use "request" in calendar templates. show_calendar tag now also accepts inherit_context argument: when set to True it will pass current context to calendar renderer.

Maybe inherit_context should be set to True by default. But this also will require changes to EventMonthView: to make things consistent it should contain all variables of all context_processors when rendering calendar just like show_calendar with new default value for inherit_context. Maybe EventMonthView should directly use show_template instead of month_display?

@wreckage
Copy link
Owner

Hello! Sorry, I don't really have time right now to delve into the code (I just started at a new school), but considering all of the important improvements you've made to the project, I trust your judgement on the correct course to take with this issue. I'll merge in the pull request if you can get the Travis build to pass (tests are important to me!). Thanks!

@imposeren
Copy link
Contributor Author

Hello @wreckage! I have fixed tests but travis still fails because of some missing file:
You have to provide either repo_token in .coveralls.yml, or launch via Travis or CircleCI

show_calendar template tag may now be used without passing request object as first argument, but it still should be available in template context. And it's still possible to pass it for backwards compatibility.

wreckage added a commit that referenced this pull request Feb 2, 2016
@wreckage wreckage merged commit 2b61853 into wreckage:master Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants