GitHub Action to run CI on Windows, Linux, Mac #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
force-pushed
the
github_actions
branch
2 times, most recently
from
f17109e
to
309e5fe
Compare
joshgoebel
changed the title
joshgoebel
force-pushed
the
github_actions
branch
from
309e5fe
to
485f883
Compare
joshgoebel
force-pushed
the
github_actions
branch
from
745981c
to
b194c62
Compare
joshgoebel
force-pushed
the
github_actions
branch
from
431359d
to
c99e68e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #90 #109
This adds a GitHub action that runs on every push and runs the full CI suite for:
It also uploads build artifacts for every platform. I share it incase it may prove helpful for anyone else doing custom things with the CLI. This also fixes 3 broken tests with the Windows test suite.
I vaguely remember a conversation with Ruby about Travis CI vs GHA - but if we aren't running the FULL suite against all platforms on Travis CI then perhaps we should at least be filling in the gaps with GitHib actions - since it's free and all? Slow is better than never when it comes to CI. (Linux is ridiculously fast at least)
It seems right now that our CI pipeline is broken if PRs can get merged into
mainwhile the test suite is still red. This is my solution to fix that. It's also possible we have a visibility problem, hence #90.