Refactor BSD build support to be extendable and add NetBSD #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure how and why it got borked, but editing in Gihub Web interface seems to have solved it.
|
Thanks @vazub looks like a reasonable approach. I'll maybe rearrange a tiny bit but otherwise will test/review properly soon. |
added 2 commits
January 9, 2022 19:39
Don't assume that people would be building on Free/NetBSD host system, be explicit.
|
Looks like there is no interest in this. Closing. |
|
The issue isn't really interest, mostly time, and the burden of testing and maintaining those platforms for each release is a consideration. I think this is a reasonable approach as mentioned, though there's a file that has it's entire contents marked as a diff which we should probably correct before this can be merged either way. |
ruby0x1
reviewed
Sep 28, 2022
|
@ruby0x1 kind request to address my question in the resolved section above, because I am not sure how to proceed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow building
wren_clifor both FreeBSD and NetBSD, and allow trivial future extension for other BSDs, if needed.Unfortunately, Premake bundles all separate BSDs under a single
system:bsddefinition, making it impossible to set up build conditionals purely with--os=option, and therefore adding additional option was required to circumvent this problem.Moreover, it made sense to define dedicated
gmake.<*bsd>folder location for each system's project files, to have clear separation of concerns, and since BSDmakeis not usable in our case, folder prefix was deliberately changed togmake.to provide additional hint for those building the project from source, regarding whatmakevariant they are required to use.