Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Process.versions #44

Closed
wants to merge 2 commits into from
Closed

Implement Process.versions #44

wants to merge 2 commits into from

Conversation

vladimyr
Copy link
Contributor

@vladimyr vladimyr commented Jun 10, 2020 •
edited
Loading

Add static versions to the Process class.

NOTE: This relies on changes proposed in wren-lang/wren#760 wren-lang/wren#725 ⚠️

@vladimyr vladimyr marked this pull request as draft June 10, 2020 04:16
@ruby0x1 ruby0x1 closed this Jun 12, 2020
@ruby0x1 ruby0x1 reopened this Jun 13, 2020
@ruby0x1 ruby0x1 changed the base branch from master to main June 13, 2020 21:24
@joshgoebel
Copy link
Contributor

Thoughts: I think a more common API I see elsewhere would be to have two getters instead... Process.wren_version and Process.uvVersion, etc.

@ruby0x1 ruby0x1 closed this Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vladimyr @joshgoebel @ruby0x1