Skip to content

Commit

Permalink
Remove the negative number tests for bitwise not.
Browse files Browse the repository at this point in the history
They were inadvertently relying on undefined behavior in C and we get
different results on some compilers.

Until we decide how we want the operation to behave, for now, just
leave it unspecified.
  • Loading branch information
munificent committed Jan 13, 2017
1 parent d301fef commit c6eb0be
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions test/core/number/bitwise_not.wren
Expand Up @@ -5,16 +5,10 @@ System.print(~23) // expect: 4294967272
// Max u32 value.
System.print(~0xffffffff) // expect: 0

// Negative numbers.
System.print(~-1) // expect: 0
System.print(~-123) // expect: 122
System.print(~-0xfffffffe) // expect: 4294967293
System.print(~-0xffffffff) // expect: 4294967294

// Floating point values.
System.print(~1.23) // expect: 4294967294
System.print(~0.00123) // expect: 4294967295
System.print(~345.67) // expect: 4294966950
System.print(~-12.34) // expect: 11

// TODO: Negative numbers.
// TODO: Numbers that don't fit in u32.

0 comments on commit c6eb0be

Please sign in to comment.