Skip to content

Commit

Permalink
Small fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
henricasanova committed Sep 29, 2017
1 parent 788f0dc commit 94fcf84
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion TODO.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@

SOFTWARE ENGINEERING:
- Unify submitJob (with compute_service_specific_arguments)

-----------------------------------

Expand All @@ -14,6 +15,9 @@ DETAILS:

DATA STORAGE IMPLEMENTATION:

- Make is so that the SimpleStorage Service overwrites files without complaining
(Wasting time)...

- Decide what to do about "partial failures"
- How do we report what has completed, and what hasn't upon failure
- Or do we leave it as is and the WMS has to inspect things?
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ namespace wrench {
// First kill the executor's main actor
// WRENCH_INFO("Killing an the main actor of a workunit executor");
this->kill_actor();
// Then kill all compute threads
// Then kill all compute threads, if any
for (unsigned long i=0; i < this->compute_threads.size(); i++) {
// WRENCH_INFO("Killing a compute thread");
this->compute_threads[i]->onExit(bye, nullptr);
Expand Down
2 changes: 1 addition & 1 deletion src/wrench/simgrid_S4U_util/S4U_Mailbox.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ namespace wrench {
try {
mailbox->put_init(msg, msg->payload)->detach();
} catch (xbt_ex &e) {
if (e.category == network_error) {
if ((e.category == network_error) || (e.category == timeout_error)) {
WRENCH_INFO("Network error while doing a dputMessage()");
throw std::shared_ptr<NetworkError>(new NetworkError(NetworkError::SENDING, mailbox_name));
} else {
Expand Down

0 comments on commit 94fcf84

Please sign in to comment.