Test Memory bug--

wrench-project · Aug 4, 2019 · dfc2113 · dfc2113
1 parent f53e346
commit dfc2113
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/wrench/managers/JobManager.cpp b/src/wrench/managers/JobManager.cpp
@@ -431,6 +431,11 @@ namespace wrench {
             throw std::invalid_argument("JobManager::forgetJob(): invalid argument");
         }
 
+        // Check the job is somewhere
+        if (this->jobs.find(job) == this->jobs.end()) {
+            throw std::invalid_argument("JobManager::forgetJob(): unknown job");
+        }
+
         if (job->getType() == WorkflowJob::STANDARD) {
 
             if ((this->pending_standard_jobs.find((StandardJob *) job) != this->pending_standard_jobs.end()) ||

diff --git a/test/compute_services/BatchService/BatchServiceTest.cpp b/test/compute_services/BatchService/BatchServiceTest.cpp
@@ -728,9 +728,11 @@ class OnePilotJobSubmissionTestWMS : public wrench::WMS {
             // Create a pilot job that needs 1 host, 1 code, 0 bytes of RAM and 30 seconds
             wrench::PilotJob *pilot_job = job_manager->createPilotJob();
             // Forgetting the job right-away for coverage
+            WRENCH_INFO("FORGETTINGJOB");
             job_manager->forgetJob(pilot_job);
             // Forgetting the job again, which is wrong,for coverage
             try {
+            WRENCH_INFO("FORGETTINGJOB AGAIN");
                 job_manager->forgetJob(pilot_job);
                 throw std::runtime_error("Should not be able to forget already forgotten pilot job");
             } catch (std::invalid_argument &e) {