Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): display notifications #79

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

wri7tno
Copy link
Collaborator

@wri7tno wri7tno commented Sep 6, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@wri7tno wri7tno force-pushed the feat/consume-notifications branch 5 times, most recently from 82b54a6 to 71b71b6 Compare September 7, 2023 23:44
@wri7tno wri7tno force-pushed the feat/consume-notifications branch 8 times, most recently from 7ab1420 to a422fc3 Compare September 15, 2023 18:17
.eslintignore Outdated Show resolved Hide resolved
@wri7tno wri7tno marked this pull request as ready for review September 15, 2023 18:29
Copy link
Collaborator

@willian-viana willian-viana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested small changes but it's ready to merge :shipit:

>
<Tooltip content="Notifications">
<div>
<NotificationGreenIcon />
{!hasNotifications && <NotificationGreenIcon />}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{!hasNotifications && <NotificationGreenIcon />}
{
{hasNotifications
? <NotificationGreenRedDotIcon />
: <NotificationGreenIcon />
}

src/components/header/index.js Outdated Show resolved Hide resolved
@wri7tno wri7tno force-pushed the feat/consume-notifications branch 3 times, most recently from 70a0816 to 4db3466 Compare September 21, 2023 00:56
@wri7tno wri7tno force-pushed the feat/consume-notifications branch 4 times, most recently from 70035a9 to 5dadf24 Compare September 25, 2023 17:09
@wri7tno wri7tno force-pushed the feat/consume-notifications branch 2 times, most recently from c4b0673 to e40ca2a Compare October 2, 2023 17:47
@wri7tno wri7tno merged commit d0d1a04 into master Oct 2, 2023
2 checks passed
@wri7tno wri7tno deleted the feat/consume-notifications branch October 2, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants