Feature/recent imagery bug and improvements #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-bug-and-improvements
edbrett
reviewed
Mar 21, 2018
| mps.publish('Layer/update', [name]); | ||
| }, | ||
|
|
||
| setSentinel: function(value) { | ||
| setRecentImagery: function(value) { |
| @@ -15,7 +15,16 @@ import closeIcon from 'assets/icons/close.svg'; | |||
| import RecentImageryDrag from './recent-imagery-settings-drag'; | |||
| import './recent-imagery-settings-styles.scss'; | |||
|
|
|||
| const CAROUSEL_SLIDES_TO_SHOW = 5; | |||
There was a problem hiding this comment.
Could this go in the reducer to keep things tidy?
| @@ -19,6 +19,7 @@ import RecentImageryDrag from './recent-imagery-drag'; | |||
| import RecentImageryComponent from './recent-imagery-component'; | |||
|
|
|||
| const LAYER_SLUG = 'sentinel_tiles'; | |||
| const MIN_ZOOM = 8; | |||
There was a problem hiding this comment.
Again both of these could go in the reducer? Might make things easier later on if we move maps.
edbrett
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR solve some bugs and improvements. You can get information about them in my commits description.