Feature/new analysis endpoint #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01painadam
reviewed
Mar 22, 2018
edbrett
suggested changes
Mar 23, 2018
| this.abortRequest(GET_REQUEST_COUNTRIES_LIST_ID); | ||
| this.currentRequest[GET_REQUEST_COUNTRIES_LIST_ID] = ds.request(requestConfig); | ||
| }.bind(this)); | ||
| return new Promise( |
There was a problem hiding this comment.
Can we make sure these are alphabetically sorted?
There was a problem hiding this comment.
Currently Norway is first.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "globalforestwatch", | |||
| "version": "3.0.1", | |||
| "version": "3.1.0", | |||
There was a problem hiding this comment.
Not sure why this is here?
There was a problem hiding this comment.
I don't know either 🤷♂️
There was a problem hiding this comment.
1 and 0 swapped places because 1 was tired of being on the window seat?
There was a problem hiding this comment.
absolutely... there can be no other explanation
|
Additional comments:
|
edbrett
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR changes the analysis url for the
umd-loss-gaindataset to use the need endpoint that @01painadam made here: gfw-api/gfw-umd-forest-api#8I've also added a new select to analyze admin2 regions.
Demo