Feature/biodiversity glads aoi widget #3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjosh
suggested changes
Mar 28, 2018
| @@ -1,4 +1,8 @@ | |||
| [ | |||
| { | |||
| "label": "4 weeks", | |||
| "value": 4 | |||
There was a problem hiding this comment.
this affects the glad-alerts widget. Is this right?
There was a problem hiding this comment.
Ah cheese 🤔 . Yes I should have put in the .env. And yes weeks selector needs updating. 🏎 💨
pjosh
approved these changes
Mar 28, 2018
|
We can review Monday morning as it doesnt have to be production until the afternoon. Provisionally looks good. |
|
A few further updates based on feedback:
Other unimplemented feedback for future reference:
|
edbrett
force-pushed
the
feature/biodiversity-glads-aoi-widget
branch
from
9a41e09
to
148f246
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A new shiny widget to display the GLAD alerts within a country of region, broken down by sub regions, and ranked by total area or relative percentage of tree cover extent.