GLAD Biodiversity Table Update #3367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fw into feature/glad_summary_tables
edbrett
suggested changes
Apr 20, 2018
app/javascript/services/alerts.js
Outdated
| @@ -1,13 +1,14 @@ | |||
| import axios from 'axios'; | |||
| import moment from 'moment'; | |||
| // import moment from 'moment'; | |||
There was a problem hiding this comment.
dont leave comments please
app/javascript/services/alerts.js
Outdated
|
|
||
| const REQUEST_URL = `${process.env.GFW_API_HOST_PROD}`; | ||
| const DATASET = process.env.GLAD_PRECALC_DATASET; | ||
| const ISO_DATASET = process.env.ISO_GLAD_SUMMARY; | ||
| const ADM1_DATASET = process.env.ADM1_GLAD_SUMMARY; |
There was a problem hiding this comment.
Can you names these by GLAD_.... instead? So they are grouped together in the alpha in heroku so easier to find.
edbrett
approved these changes
Apr 23, 2018
|
Glad tables are now updated with the following id's for the They just need testing on staging first - then we are good to go! |
…fw into feature/glad_summary_tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates the GLAD Biodiversity Widget to use the new summary tables (pre-aggregated by week, and pre-grouped by either adm1 or adm2 ). Makes requests fast! 🔥
No Aesthetic changes.
Note that the summary tables are not yet synced with the current GLAD table, so data will not match when testing