Feature/refactor components #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/widget refactoring
|
I've found a problem loading the glad layer on the country pages. I don't see any errors, but the layer doesn't load. |
edbrett
force-pushed
the
feature/refactor-components
branch
from
e3b8cef
to
c2a9dc1
Compare
pjosh
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, I apologise for the size of the changes in this PR. It was impossible to break this down further.
This address DRY issues in the country page widgets, improving maintainability, performance of widget rendering, reduced fetching, and several fixes for property propagation and selector performance.
Please review with caution.