Feature/request cache #3418
Merged
Feature/request cache #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure/local-cache
…ure/request-cache
edbrett
reviewed
May 18, 2018
| @@ -95,6 +100,13 @@ We follow a [Gitflow Worklow](https://www.atlassian.com/git/tutorials/comparing- | |||
|
|
|||
| .svg) | |||
|
|
|||
| #### Clear Redis cache | |||
| If you need to clear the Redis cache after deploy, run these commands on your local terminal: | |||
There was a problem hiding this comment.
Can we automate this to happen on build? So when we deploy the cache is flushed?
There was a problem hiding this comment.
I think it will not be possible 😭 😭 I've spent almost the whole day yesterday, trying to find a solution, but Heroku is a very hard bastard. I wanted to talk to someone expert in Heroku to see if he could come up with any solution.
There was a problem hiding this comment.
Well that is very annoying. maybe @simaob can help?
edbrett
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This awesome feature prevents potencial issues when our external data sources fall.
Basically, we store the data source endpoints in a RedisDB. After that, we always try to get the information from Redis (much faster and reduces charge on the API).
The cache expires in 24h by default, but you can set other duration. Besides that, you can set cache exceptions if you need to cache the request but sometimes not.
Test
It's fully integrated in the country pages. If you don't have Redis on you machine, run this command:
brew install redis