update to emissions widget defaults and calculation order #3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbrett
suggested changes
Aug 2, 2018
edbrett
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emissions from Charlies table comes back in Mg/ha (i.e. tonnes/ha). This value, converted to CO2 should be the default for the emissions widget. This PR makes it default, and also calculates it in a different way (summing the annual values in Mg/ha first, and then converting) so that the values are consistent with the values quoted in the loss widget too.
Emissions loss value should match value quoted in TC loss widget.
CO2 should be default choice.
