Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/code split reducers #3673

Merged
merged 16 commits into from
Jan 9, 2019
Merged

Feature/code split reducers #3673

merged 16 commits into from
Jan 9, 2019

Conversation

edbrett
Copy link
Contributor

@edbrett edbrett commented Dec 13, 2018

Overview

Sometimes in life things don't turn out the way you expect them too. This can be something you realise slowly, over many years as your life gently slips into a montage of desperate chaos. It can also happen suddenly and abruptly. Like when @sorodrigo informs you that you don't know cheese about code splitting and ES6 imports and you have been importing your entire reducer tree into you main app pack all along and your entire app is a lie.

Unlike a messy and problematic life full of poor choices, code splitting reducers isn't actually that hard. It took a similar amount of emotional effort to fix but with this PR both GFWs life and code splitting are back on track.

Core therapy methods have been:

  • splitting reducers using a registry in the app folder
  • refactor selectors to handle dynamic reducers

TODO:

  • Split map menu so that is isn't importing actions into the root.
  • Events for new module maps

@edbrett edbrett changed the base branch from feature/module-maps to develop December 13, 2018 18:17
@edbrett edbrett added the develop Any PR that is ready to be merged to develop label Jan 9, 2019
@edbrett edbrett merged commit c9ae5cb into develop Jan 9, 2019
@edbrett edbrett deleted the feature/code-split-reducers branch January 9, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Any PR that is ready to be merged to develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant