Feature/future carbon gains #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm getting a "Network Error" on every request, maybe there is some CORS issues between the domains climate.globalforestwatch.org and www.globalforestwatch.org ? |
|
can you share an example request? |
|
Sure! This is one example. You can access it from the browser, and even the network tools are giving me 200s and 304s status codes, but I can't seem to get the data in the widget itself. |
dfrico
added
develop
benlaken
suggested changes
Jan 10, 2019
edbrett
added
WIP
dfrico
added
develop
edbrett
suggested changes
Jan 15, 2019
| @@ -0,0 +1,50 @@ | |||
| export default { | |||
| widget: 'futurecarbongains', | |||
There was a problem hiding this comment.
can we camelCase this like other widgets?
| if (isEmpty(data)) return null; | ||
| const years = {}; | ||
| const selectedData = data[settings.unit]; | ||
| Object.keys(selectedData).forEach(key => |
There was a problem hiding this comment.
you could use a reduce here to make this simpler.
| label: labels[k] ? labels[k] : k, | ||
| color: colors.ramp && colors.ramp[i], | ||
| unit: 't', | ||
| unitFormat: num => formatNumber({ num, unit: '' }) |
There was a problem hiding this comment.
This is ugly, but appreciated we dont have too many options right now. Going to make a note to improve this.
edbrett
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview - Future Carbon Gains widget
This one is a version of the Potential tree biomass gain widget for the climate tab. It features a stacked bar chart to show Potential tree biomass gain of Young Secondary Forests, Mid-Age Secondary Forests, Pasture Area, and Crops.