Feature/cumulative emissions widget #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfrico
added
staging
edbrett
suggested changes
Feb 8, 2019
| @@ -0,0 +1,50 @@ | |||
| export default { | |||
| widget: 'firesAlerts', | |||
There was a problem hiding this comment.
this needs to change otherwise we have two widgets with the same
| analysis: true, | ||
| types: ['country'], | ||
| admins: ['adm0'], | ||
| layers: [], |
There was a problem hiding this comment.
if no layers remove this key.
edbrett
suggested changes
Feb 13, 2019
| if (!data || isEmpty(data)) return null; | ||
|
|
||
| const { variable } = settings; | ||
| const target = variable === 'cumulative_emissions' ? 265000000 : 988880; |
There was a problem hiding this comment.
Can we clarify what these numbers are and place them as CONSTS at the top.
…uality/gfw into feature/cumulative-emissions-widget
edbrett
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Weekly forest disturbance alerts to track forest loss and emissions. This widget features a line chart showing cumulative emissions and area of loss. It replicates the behaviour of the glad alerts widget from climate GFW.
Demo