BUG: Parent attribute not present past items in root group (#749)

* BUG: Only append slash for root when accessing parent * TST: Add nested collection parent test * Fix test
wright-group · Sep 20, 2018 · 3e701be · 3e701be
1 parent 5829bf4
commit 3e701be
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/WrightTools/_group.py b/WrightTools/_group.py
@@ -231,7 +231,9 @@ def parent(self):
         except (AssertionError, AttributeError):
             from .collection import Collection
 
-            key = posixpath.dirname(self.fullpath) + posixpath.sep
+            key = posixpath.dirname(self.fullpath)
+            if key.endswith("::"):
+                key += posixpath.sep
             self._parent = Collection._instances[key]
         finally:
             return self._parent

diff --git a/tests/base.py b/tests/base.py
@@ -27,8 +27,10 @@ def test_named_root_data():
 def test_parent_child():
     parent = wt.Collection(name="mother")
     child = wt.Collection(parent=parent, name="goose")
+    grandchild = wt.Collection(parent=child, name="hen")
     assert child.filepath == parent.filepath
     assert child.parent is parent
+    assert grandchild.parent is child
 
 
 def test_single_instance_collection():