New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate GTK app Code.as / GitHub repos #28
Conversation
The gb project is unmaintained, and `go` has gained many of it's features. Because of this `go build` can now be used without issue. Related to T639
Since `go build` is used instead of `gb build`, the buildsystem can fetch from non-GitHub hosts. The bundled source code is no longer necessary. Related to T639
This is the final step for T639. Consolidates both builds into one build by using meson to configure the app id and file names at build time. Also changes the build commands in the debian/rules file in order to use the new system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks @BrainBlasted!
Changes all look good to me -- it just looks like there's a build issue with elementary's stuff. Could you take a look at that? Or should we fix that separately?
The latest version of the CLI repositiory supports Go modules.
Instead of using the default go buildsystem with $GOPATH, the build script takes advantage of go modules pulling in the dependencies automatically with `go build`.
`go get` allows the buildsystem to fetch dependencies for the cli, then build locally.
Since the buildsystem uses `go get`, this submodule is no longer necessary.
This allows the buildsystem to know for sure where GOPATH is, and ensures GOPATH sticks around for houston CI.
Remove `gb` and add `git`
ae1e400
to
78fdb06
Compare
This reverts commit 78fdb06.
This reverts commit 622abdb.
This reverts commit df4e325.
This reverts commit 3faef3e.
This reverts commit 3cc8527.
This reverts commit 3cdab63.
This reverts commit 2b1e512.
Previously success would be printed regardles.
gopass is now required to build writeas-cli.
This reverts commit 3b3ab06.
This reverts commit 276834b.
I "fixed" it, but that involved reverting the changes around |
Alright, sounds good. We should be set for the scope of this task, at least. Do we need to update the build instructions in the README, too? With a clean repo, when I run
|
You need to do a recursive clone or initialize the submodules after cloning. |
Note: that aspect isn't different from the current master branch. So the directions could use an update, but that's unrelated to this PR. |
Thanks, I'd forgotten about that. Everything builds just fine 👍 There's just one last difference between the normal Code.as build and the GitHub / elementary version: the Code.as build didn't include the changes in #14. If it's possible, and if there's no compelling reason not to do this, I'd like to keep the small icons in the |
Translates writeas#14 to the consolidated build. Finishes off T639
Done. I think this should be good to go once this pipeline finishes. |
Awesome, looks great! Merging now. |
This PR takes care of the work needed to bring the Code.as and GitHub codebases into one space. The main changes: