OAuth tidy-up and refactor #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, these display names were swapped.
This moves fields into the `OAuthButtons` struct and puts the buttons into templates/includes/oauth.tmpl.
This updates signup.tmpl to include all supported OAuth methods and respect the new `DisablePasswordAuth` config value.
This includes the platform mark with each login button and uses brand colors. It also uses the same style on the Account Settings page. And it wraps buttons on login / signup pages.
|
Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
in-progressPR tidies up OAuth-related code from #293 and #317:OAuthButtonsstruct for easier maintenance in the futureDisablePasswordAuthconfigNew branded button design:
Login / signup
Account Settings