Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestPostLede fails #316

Closed
Bridouz opened this issue Jun 5, 2020 · 1 comment
Closed

TestPostLede fails #316

Bridouz opened this issue Jun 5, 2020 · 1 comment
Assignees
Milestone

Comments

@Bridouz
Copy link

@Bridouz Bridouz commented Jun 5, 2020

Trying to package writefreely for Alpine Linux (busybox/musl libc)
Build is OK but Tests fail at :

=== RUN   TestPostLede
    TestPostLede: posts_test.go:34: #2: Got 'Sup? Everyone says punctuation is punctuation.' from 'Sup? Everyone says punctuation is punctuation.'; expected 'Sup?'
--- FAIL: TestPostLede (0.00s)

Packaging is using :

make build
make test

Requirements are `go, go-bindata, sqlite, nodejs-less, nodejs-less-plugin-clean-css"

Version or last commit:

  • v0.12.0
@thebaer
Copy link
Member

@thebaer thebaer commented Jun 11, 2020

Thanks for the report, @Bridouz! A fix should be pretty straightforward -- in the PostLede func, we just need to look for the ? character.

For anyone interested in fixing this, feel free to open a pull request!

@thebaer thebaer self-assigned this Sep 2, 2020
thebaer added a commit that referenced this issue Sep 2, 2020
This fixes TestPostLede and closes #316.
@thebaer thebaer added this to the 0.13 milestone Sep 2, 2020
@thebaer thebaer closed this in #381 Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants