Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Sponsor brand mandatory key #1328

Closed
plaindocs opened this issue Aug 25, 2020 · 0 comments · Fixed by #1623
Closed

Make Sponsor brand mandatory key #1328

plaindocs opened this issue Aug 25, 2020 · 0 comments · Fixed by #1623
Assignees
@mxsasha

Comments

@plaindocs
Copy link
Contributor

When validating yaml the sponsor key should be mandatory.

index 5964e167..e21e65e2 100644
--- a/docs/_data/schema-config.yaml
+++ b/docs/_data/schema-config.yaml
@@ -126,7 +126,7 @@ sponsors-details:
 sponsor-detail:
   name: str(required=True)
   link: str(required=True)
-  brand: str(required=False)
+  brand: str(required=True)
   text: str(required=False)
   width: str(required=False)

unsure if this will break pre 2020 configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxsasha mxsasha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1328 - Make sponsor brand key mandatory writethedocs/www
2 participants
@plaindocs @mxsasha