Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tools output plus mobile layout #71

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix tools output plus mobile layout #71

merged 1 commit into from
Apr 17, 2024

Conversation

vood
Copy link
Contributor

@vood vood commented Apr 17, 2024

Fixes #70 #69


Ellipsis 🚀 This PR description was created by Ellipsis for commit 54a89a7.

Summary:

This PR improves mobile layout and fixes the output of tools by adjusting CSS classes, modifying response format, moving a function, and removing console logs.

Key points:

  • Adjusted CSS classes in page.tsx, chat-ui.tsx, message.tsx, and model-settings.tsx for better mobile responsiveness.
  • Modified the response format in route.ts to include a newline character.
  • Moved the parseDataStream function from index.ts to consume-stream.ts.
  • Removed some console log statements in index.ts.

Generated with ❤️ by ellipsis.dev

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
labs ✅ Ready (Inspect) Visit Preview Apr 17, 2024 0:05am

@vood vood merged commit e433e77 into main Apr 17, 2024
2 checks passed
@vood vood deleted the bugfix/tools-parsing-1 branch April 17, 2024 00:06
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested.

  • Reviewed the entire pull request up to 54a89a7
  • Looked at 223 lines of code in 7 files
  • Took 1 minute and 45 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 0 additional comments because they didn't meet confidence threshold of 50%.

Workflow ID: wflow_oku6WTa3ZMVeCic9


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.

⌛ You have 1 day remaining in your free trial. Upgrade at https://app.ellipsis.dev for $20/developer/month. If you have any questions, reach us at help@ellipsis.dev

const code = prefix as keyof typeof streamPartsByCode

const textValue = line.slice(firstSeparatorIndex + 1)
console.log("textValue", textValue)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the console.log statement. It's generally a good practice to clean up debugging statements before committing code.

@@ -376,6 +336,8 @@ export const processResponse = async (
setFirstTokenReceived(true)
setToolInUse("none")

console.log("chunk", chunk, selectedTools.length)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the console.log statements. It's generally a good practice to clean up debugging statements before committing code.

@@ -30,3 +32,44 @@ export async function consumeReadableStream(
reader.releaseLock()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the console.log statement. It's generally a good practice to clean up debugging statements before committing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile version: Sections overlap in Top menu
1 participant