-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tools output plus mobile layout #71
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested.
- Reviewed the entire pull request up to 54a89a7
- Looked at
223
lines of code in7
files - Took 1 minute and 45 seconds to review
More info
- Skipped
0
files when reviewing. - Skipped posting
0
additional comments because they didn't meet confidence threshold of50%
.
Workflow ID: wflow_oku6WTa3ZMVeCic9
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. We'll respond in a few minutes. Learn more here.
⌛ You have 1 day remaining in your free trial. Upgrade at https://app.ellipsis.dev for $20/developer/month. If you have any questions, reach us at help@ellipsis.dev
const code = prefix as keyof typeof streamPartsByCode | ||
|
||
const textValue = line.slice(firstSeparatorIndex + 1) | ||
console.log("textValue", textValue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the console.log statement. It's generally a good practice to clean up debugging statements before committing code.
@@ -376,6 +336,8 @@ export const processResponse = async ( | |||
setFirstTokenReceived(true) | |||
setToolInUse("none") | |||
|
|||
console.log("chunk", chunk, selectedTools.length) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the console.log statements. It's generally a good practice to clean up debugging statements before committing code.
@@ -30,3 +32,44 @@ export async function consumeReadableStream( | |||
reader.releaseLock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the console.log statement. It's generally a good practice to clean up debugging statements before committing code.
Fixes #70 #69
Summary:
This PR improves mobile layout and fixes the output of tools by adjusting CSS classes, modifying response format, moving a function, and removing console logs.
Key points:
page.tsx
,chat-ui.tsx
,message.tsx
, andmodel-settings.tsx
for better mobile responsiveness.route.ts
to include a newline character.parseDataStream
function fromindex.ts
toconsume-stream.ts
.index.ts
.Generated with ❤️ by ellipsis.dev