Issue 31 #32
Issue 31 #32
Conversation
| $this->ImageReplacer($dpi); | ||
| public function retrieveFilesList($file, $stats) { | ||
| $this->exctractOpenXmlFile($file); | ||
| if(substr($file,-3) === 'xml' && substr($file,0,4) === 'word') { |
There was a problem hiding this comment.
I would like to have a more targeted approach for this to save any kind of additional work (as I see the class already performance lacking). Every XML file seems to be a little overkill, as far as I can tell, as some docx files have many meta files that do not need to be touched.
I would probably generate something like a whitelist. Relevant files might include xml files in the subfolder word: document.xml, endnotes.xml, footer*.xml, footnotes.xml, header*.xml. There might be more files that are relevant, I haven't done the research on the structure, but the whitelist could be expanded in the future accordingly.
Thoughts?
There was a problem hiding this comment.
You could be right. I will change my code accordingly.
#31