Compile regexes #14
Merged
Compile regexes #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recompiling regex over and over is slow. This change compiles them only once.
|
Pull-request updated, HEAD is now 1841f5e |
|
Changes Unknown when pulling 1841f5e on sileht:master into ** on wroberts:master**. |
2 similar comments
|
Changes Unknown when pulling 1841f5e on sileht:master into ** on wroberts:master**. |
|
Changes Unknown when pulling 1841f5e on sileht:master into ** on wroberts:master**. |
jd
approved these changes
Aug 30, 2017
chungg
approved these changes
Aug 31, 2017
|
@wroberts we're really eager to have this merged and release. Anything we can do to help? |
|
Looks good, people! Thanks for the PR. Just released 1.1.7. |
|
You rock @wroberts, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recompiling regex over and over is slow.
This change compiles them only once.