(Session Three) Fixes file.c nameLen member usage #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
file.c
exercice of the session three,info->nameLen
seems to not work as intended :I've restored it to its percieved intended usage : set when reading the username file (discarding the linefeed char) and used to properly bound the password calculation/check.
Also fixes some minor typos in error messages while i was at it.
There's also some issues with
malloc
not being properlyfree
d but i think that's mostly done to keep the code structure simpler to RE.If this PR goes in, the binary will have to be regenerated too.
Please disregard if irrelevant, thanks for the good course anyway !