Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12 py.test-3.3.1 compatibility #13

Closed
wants to merge 1 commit into from
Closed

Fix #12 py.test-3.3.1 compatibility #13

wants to merge 1 commit into from

Conversation

spacelis
Copy link

Py.test changed (pytest-dev/pytest@22f338d) the method name from suspendcapture to suspend_global_capture which breaks this plugin.

@spacelis spacelis mentioned this pull request Dec 30, 2017
Closed
wronglink
wronglink requested changes Jan 7, 2018
View reviewed changes
Copy link
Owner

@wronglink wronglink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spacelis thanks for your contribution. Right now I can't merge this PR as it would break pre 3.3.1 compatibility. We need some comat layer for both suspendcapture and suspend_global_capture to work.

@noirbizarre noirbizarre mentioned this pull request Feb 13, 2018
Merged
@wronglink wronglink closed this in c4b35b7 Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wronglink wronglink wronglink requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spacelis @wronglink