Fix TLS behavior #17
Merged
Fix TLS behavior #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TLS SNI was not being sent by default. The `tls_sni_name` option has been added to allow explicit control and common sense defaults added. When a hostname is specified and `tls_enabled` is true, the system will default to sending a TLS SNI name of the hostname. If a URL is specified with a valid hostname, then the system will send an SNI name matching the Hostname portion (without the port specification). All SNI handling can be overridden by specifying a fixed `tls_sni_name`, but the default behavior should be unsurprising.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| tlsConfig := &tls.Config{InsecureSkipVerify: true} //nolint:gosec | ||
| tlsConfig := &tls.Config{ | ||
| ServerName: s.tlsSniName, | ||
| InsecureSkipVerify: true, //nolint:gosec |
Check failure
Code scanning / CodeQL
Disabled TLS certificate check
This was referenced Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http_response_received_boolspelling