Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Thread Locking: Move Protocol Negotiation to Main Loop #30

Open
wrparker opened this issue Sep 20, 2020 · 0 comments
Open

Prevent Thread Locking: Move Protocol Negotiation to Main Loop #30

wrparker opened this issue Sep 20, 2020 · 0 comments

Comments

@wrparker
Copy link
Owner

wrparker commented Sep 20, 2020

Currently, protocol negotiation for a player happens all together. This means that all actions from other players are paused in the MUD until protocol negotiation is completed. Ideally, we should move protocol negotiation so that it is handled in the main loop rather than doing it all together.

The reason for this is because waiting for timeouts on protocol negotiation causes all other players to freeze until that player's telnet protocol negotiations are complete.

i.e.: the functions in alluvian/server/protocol.py should be handled similarly to how the Login system is handled so the thread isn't locked to a player every time they connect.

An alternative, hacky solution would be to give a very small response time allowed for protocol negotiation (currently it is set to 2 seconds).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant