309.1 not Installing Readme Files

[AndalayBay]

I asked about this issue on Discord and got ignored.

Bash won't install a readme file at the root of the archive if it doesn't have "readme" in the name. For example, Roads of Cyrodiil https://www.afkmods.com/index.php?/files/file/259-roads-of-cyrodiil/
It won't install "Roads of Cyrodiil.txt". It will however install any text file if it's in a folder - no matter the name. Or it will install a text file at the root if it has "readme" in the name. I right-clicked on the archive and selected Override Skips and it didn't make any difference. I also clicked on Has Extra Directories and that didn't help either.

This works just fine in 307. I know you guys have some stuff about archives being organized a certain way, but I'm not going to repackage all my mods just so Bash installs them properly. These are mods I didn't create.

[Infernio]

You almost certainly didn't get ignored, your post just got buried. We are all volunteers and have busy lives outside of maintaining an open source project for free, which means we miss messages - especially if we wake up and see 50+ new messages on the Discord.

The proper course of action in such a situation is to simply post your message in the forum/server again after it hasn't received a response for a while - and if that still doesn't get a response, feel free to ping @Developers on the Discord.

As for this report, I'm on mobile right now and hence can't determine if this is a legitimate bug. I'll try to take a look tomorrow, if I have time.

[Infernio]

This works just fine in 307.

It actually doesn't:

That's because WB has always just looked for files with something like readme (or lisezmoi, interestingly) in their names:

• dev:

  wrye-bash/Mopy/bash/bosh/bain.py

  Lines 77 to 79 in 8b2e673

  	reReadMe = re.compile(
  	r'^.*?([^\\]*)(read[ _]?me|lisez[ _]?moi)([^\\]*)'
  	u'(' + u'|'.join(docExts) + u')$', re.I | re.U)

• 307:

  wrye-bash/Mopy/bash/bosh/bain.py

  Lines 76 to 78 in 8e19291

  	reReadMe = re.compile(
  	u'' r'^.*?([^\\]*)(read[ _]?me|lisez[ _]?moi)([^\\]*)'
  	u'(' + u'|'.join(docExts) + u')$', re.I | re.U)

I've gone ahead and refactored/fixed all this up. It now works as expected in the newest nightly (310.202202051316):

There is an open issue for making this work better (#40), so closing this in favor of that issue.