Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛: [iOS] Fixed an issue where animations were not executed in the Picker component. #889

Merged
merged 8 commits into from
Jul 22, 2022

Conversation

creature-water-valley
Copy link

@creature-water-valley creature-water-valley commented Jul 4, 2022

✅ What's done


Tests

  • Keystroke on demo screen

以下のコマンドのいずれかをこのプルリクエストのコメントとして投稿すると、
Azure Pipeline上でSantokuAppをビルドしてDeployGateへアップロードできます。
4種全てのビルドバリアントを対象にする場合はdeploy-all、
特定のビルドバリアントだけを対象にする場合はdeploy-ビルドバリアント名のコマンドを利用してください。

  • /azp run deploy-all
  • /azp run deploy-devSantokuAppDebugAdvanced
  • /azp run deploy-devSantokuAppReleaseInHouse
  • /azp run deploy-santokuAppDebugAdvanced
  • /azp run deploy-santokuAppReleaseInHouse

Devices

  • 動作確認に利用したデバイスにチェックをつけてください
  • iOS
    • シミュレータ (iPhone 13/iOS 15)
    • 実機 (iPhone 13 mini/iOS 15)
  • Android
    • エミュレータ (Pixel 3a/Android 11)
    • 実機 (Pixel 3a/Android 11)

Other (messages to reviewers, concerns, etc.)

none

@creature-water-valley
Copy link
Author

/azp run deploy-devSantokuAppReleaseInHouse

@github-actions github-actions bot added the app label Jul 4, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@creature-water-valley creature-water-valley enabled auto-merge (squash) July 4, 2022 04:41
@creature-water-valley
Copy link
Author

/azp run deploy-devSantokuAppReleaseInHouse

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@creature-water-valley
Copy link
Author

Not fixed on Release mode.

@creature-water-valley
Copy link
Author

/azp run deploy-devSantokuAppReleaseInHouse

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@creature-water-valley
Copy link
Author

/azp run deploy-devSantokuAppReleaseInHouse

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@creature-water-valley creature-water-valley merged commit c2e22f5 into master Jul 22, 2022
@creature-water-valley creature-water-valley deleted the fix/picker-animation-not-running branch July 22, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants