Merge pull request #58 from wsfe/feat/memory-leak-mitigation-2.x

feat: memory leak mitigation 2.x
wsfe · Jun 10, 2023 · d20c6b4 · d20c6b4
2 parents 0f9928a + 6e539b4
commit d20c6b4
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 14 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@wsfe/ctree",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "main": "./dist/ctree.umd.min.js",
   "types": "./types",
   "description": "A vue tree component using virtual list.",

diff --git a/src/components/Tree.vue b/src/components/Tree.vue
@@ -813,22 +813,26 @@ export default (Vue as VueConstructor<Vue & {
       this.debounceTimer = window.requestAnimationFrame(this.updateRenderNodes.bind(this, true))
       // this.updateRenderNodes(true)
     },
+
+    initializeNonReactiveData (): void {
+      const { keyField, ignoreMode, filteredNodeCheckable, cascade, defaultExpandAll, load, expandOnFilter } = this
+      this.nonReactive = {
+        store: new TreeStore({
+          keyField,
+          ignoreMode,
+          filteredNodeCheckable,
+          cascade,
+          defaultExpandAll,
+          load,
+          expandOnFilter,
+        }),
+        blockNodes: [],
+      }
+    },
   },
   created () {
     // Initial non-reactive
-    const { keyField, ignoreMode, filteredNodeCheckable, cascade, defaultExpandAll, load, expandOnFilter } = this
-    this.nonReactive = {
-      store: new TreeStore({
-        keyField,
-        ignoreMode,
-        filteredNodeCheckable,
-        cascade,
-        defaultExpandAll,
-        load,
-        expandOnFilter,
-      }),
-      blockNodes: [],
-    }
+    this.initializeNonReactiveData()
 
     this.nonReactive.store.on('visible-data-change', this.updateBlockNodes)
     this.nonReactive.store.on('render-data-change', this.updateRender)
@@ -860,6 +864,7 @@ export default (Vue as VueConstructor<Vue & {
     if ($iframe.contentWindow) {
       $iframe.contentWindow.removeEventListener('resize', this.updateRender)
     }
+    this.initializeNonReactiveData()
   },
   watch: {
     value (newVal: VModelType) {