Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More handlers and dedup code #3

Merged
merged 1 commit into from
Aug 29, 2017
Merged

More handlers and dedup code #3

merged 1 commit into from
Aug 29, 2017

Conversation

wshafer
Copy link
Owner

@wshafer wshafer commented Aug 29, 2017

Added SamplingHandler
Added NullHandler
Added PsrHandler
Added TestHandler

Converted ClientTrait to ServiceTrait to cut down on
un-needed code duplication

Added NullHandler
Added PsrHandler
Added TestHandler

Converted ClientTrait to ServiceTrait to cut down on
un-needed code duplication
@codecov-io
Copy link

codecov-io commented Aug 29, 2017

Codecov Report

Merging #3 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #3      +/-   ##
===========================================
+ Coverage        99%   99.1%   +0.09%     
+ Complexity      271     265       -6     
===========================================
  Files            82      86       +4     
  Lines          1010    1002       -8     
===========================================
- Hits           1000     993       -7     
+ Misses           10       9       -1
Impacted Files Coverage Δ Complexity Δ
src/Service/AbstractServiceManager.php 100% <ø> (+2.38%) 16 <0> (ø) ⬇️
src/Handler/SwiftMessageTrait.php 100% <ø> (ø) 4 <0> (ø) ⬇️
src/Handler/RavenHandlerFactory.php 100% <100%> (ø) 1 <0> (-3) ⬇️
src/Handler/AmqpHandlerFactory.php 100% <100%> (ø) 1 <0> (-3) ⬇️
src/Handler/RedisHandlerFactory.php 100% <100%> (ø) 1 <0> (ø) ⬇️
src/Handler/NullHandlerFactory.php 100% <100%> (ø) 1 <1> (?)
src/Handler/ElasticSearchHandlerFactory.php 100% <100%> (ø) 1 <0> (ø) ⬇️
src/Handler/MongoDBHandlerFactory.php 100% <100%> (ø) 1 <0> (ø) ⬇️
src/Handler/HandlerMapper.php 100% <100%> (ø) 46 <0> (+4) ⬆️
src/Handler/GelfHandlerFactory.php 100% <100%> (ø) 1 <0> (-3) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbc01cc...bb7afaf. Read the comment docs.

@wshafer wshafer merged commit 6057b3b into master Aug 29, 2017
wshafer added a commit that referenced this pull request Sep 21, 2017
More handlers and dedup code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants