Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FFMPEG an optional dependency in lieu of ImageMagick #239

Closed
WSLUser opened this issue Aug 10, 2022 · 5 comments
Closed

Make FFMPEG an optional dependency in lieu of ImageMagick #239

WSLUser opened this issue Aug 10, 2022 · 5 comments
Labels
Enhancement This is either an issue that describes ehcmnt./feature or a PR that introduces ehcmnt./feature Status: Patched This is fixed and is part of a released version. Target: 4.x This is targeted to the 4.x release.
Milestone

Comments

@WSLUser
Copy link

WSLUser commented Aug 10, 2022

ImageMagick has rather poor performance as has been been demonstrated by TUI library projects like chafa (who is actually considering the switch to FFMPEG) and notcurses and as noted here brings in a ton of extra dependencies . So since you plan on making ImageMagick an optional dependency: #236, it would then make sense to offer an alternative in addition to ImageMagick. This is where https://github.com/FFmpeg/FFmpeg comes in. I hope when you have time, you'll consider using FFMPEG for this project and not just ImageMagick.

@patrick330602 patrick330602 added Enhancement This is either an issue that describes ehcmnt./feature or a PR that introduces ehcmnt./feature Target: 4.x This is targeted to the 4.x release. labels Aug 11, 2022
@patrick330602
Copy link
Member

After quick checking, I will add this as part of wslu 4.0. Will work on this.

@patrick330602 patrick330602 added the Status: In Progress This is being worked on and not ready. label Aug 11, 2022
@WSLUser
Copy link
Author

WSLUser commented Aug 17, 2022

Adding https://github.com/marioroy/ffmpeg-on-clear-linux so we don't have to leave Clear Linux out of the mix.

@patrick330602
Copy link
Member

I will have to move this to 4.1... Right now I will be focus on delivering the version 4.0 first.

@patrick330602 patrick330602 added this to the 4.1 milestone Aug 18, 2022
@WSLUser
Copy link
Author

WSLUser commented Aug 18, 2022

Yes hoping you'll release 4.0 soon.

@WSLUser
Copy link
Author

WSLUser commented Oct 3, 2022

I noticed you added some preliminary code to use FFMPEG. Looking forward to testing it out once you've done your own testing and finalize the code.

@patrick330602 patrick330602 added Status: Pending Release This is fixed but not yet released. and removed Status: In Progress This is being worked on and not ready. labels Dec 24, 2022
@patrick330602 patrick330602 added Status: Patched This is fixed and is part of a released version. and removed Status: Pending Release This is fixed but not yet released. labels Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This is either an issue that describes ehcmnt./feature or a PR that introduces ehcmnt./feature Status: Patched This is fixed and is part of a released version. Target: 4.x This is targeted to the 4.x release.
Projects
Status: Done
Development

No branches or pull requests

2 participants