Add support for <select multiple>

[gregleveque]

Closes #13

[coveralls]

Pull Request Test Coverage Report for Build 79

• 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 66:	0.0%
Covered Lines:	74
Relevant Lines:	74

---

💛 - Coveralls

[wsmd]

Nice work, @gregleveque! Thanks for taking the time to work on this PR!

I have a few suggestions:

I was initially thinking that a multiple select can be used like this:

<input {...input.multiple('input-name')} />

// or maybe as it was suggested in issue #13 which I really like
<input {...input.selectMultiple('input-name')} />

Here's why:

With the current implementation it might not be clear that the second argument opt is an option argument. Especially when most of the other inputs accept a second as a value attribute.

For example:

<input {...input.radio('foo', 'foo-val') /> // 2nd arg is the input value

<input {...input.checkbox('bar') />
<input {...input.checkbox('bar', 'bar-val') /> // 2nd arg is the input value

<input {...input.select('baz') />
<input {...input.select('baz', 'multiple') /> // 2nd arg is NOT the input value!

Even from an implementation perspective, you see how in the code we're calling that argument ownValue, so It can be a little confusing.

Therefore, this might not be very intuitive or consistent with the rest of the methods.

I'm in favor of inputs.selectMultiple which I think could work very well with intellisense/autocomplete! Let's go with that.

<input {...input.select('foo') />
<input {...input.selectMultiple('foo')} />

This brings to my second point. Could you please add typings for newly added method? The typings can be found here in this file:

react-use-form-state/src/index.d.ts

Lines 15 to 16 in 14e3cd7

	interface Inputs {
	select(name: string): Omit<InputProps, 'type'>;

Lastly, can I ask you to add some tests before I merge this. It would be ideal if there's a full test coverage.

Thanks again for the PR! 🙌

[gregleveque]

I'm currently struggling for testing multiple select, because it's a CTRL + click event and the target value is only the last selected option.

The current test check if it handle an array of values but I can't add a new value because I can't find a way to implement this event.

[wsmd]

Nice job adding those tests!

I left a few comments about testing selecting multiple options and deselecting options. There's also a small linter error about an unused variable.

[wsmd]

This looks good! Thanks! 🙌

[gregleveque]

Thank you for this awsome Hook 👍