Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation bug preventing divide and conquer loop parallelization #38

Closed
timkaler opened this issue Jan 30, 2018 · 1 comment
Closed

Compilation bug preventing divide and conquer loop parallelization #38

timkaler opened this issue Jan 30, 2018 · 1 comment

Comments

@timkaler
Copy link

To reproduce: https://github.mit.edu/Supertech-Connectomics/sift_features/tree/1-24-2018-tapir-bug (branch 1-24-2018-tapir-bug) and checkout commit 95540f89caf784d42f6b8ca4614efd10328edbf3 on that branch.

A workaround that appears to avoid the compilation problem is to change the return value of Section::parameter_optimization to be void (and return result via argument reference).
neboat added a commit that referenced this issue Feb 8, 2018
@neboat
[Tapir] Handle structure-return parameters correctly in outlined help…
1a23733 
…er functions. This commit addresses issue #38.
@neboat neboat mentioned this issue Feb 8, 2018
Merged
neboat added a commit that referenced this issue Feb 8, 2018
@neboat
[Tapir] Handle structure-return parameters correctly in outlined help…
85ff377 
…er functions. This commit addresses issue #38.
@neboat
Copy link
Collaborator

neboat commented Feb 9, 2018

I've tested the committed fix on the source code specified in this issue, and I now observe no errors in compilation.

@neboat neboat closed this as completed Feb 9, 2018
neboat added a commit that referenced this issue Feb 16, 2018
@neboat
[Tapir] Handle structure-return parameters correctly in outlined help…
4657bd3 
…er functions. This commit addresses issue #38.
neboat added a commit that referenced this issue Mar 24, 2018
@neboat
[Tapir] Handle structure-return parameters correctly in outlined help…
a14415b 
…er functions. This commit addresses issue #38.
wsmoses pushed a commit that referenced this issue Nov 1, 2018
@neboat @wsmoses
[Tapir] Handle structure-return parameters correctly in outlined help…
9601d4a 
…er functions. This commit addresses issue #38.
stelleg pushed a commit to stelleg/Tapir-LLVM that referenced this issue Dec 19, 2018
@neboat @stelleg
[Tapir] Handle structure-return parameters correctly in outlined help…
18ed3cd 
…er functions. This commit addresses issue wsmoses#38.
stelleg pushed a commit to stelleg/Tapir-LLVM that referenced this issue Dec 20, 2018
@neboat @stelleg
[Tapir] Handle structure-return parameters correctly in outlined help…
17f1d0e 
…er functions. This commit addresses issue wsmoses#38.
stelleg pushed a commit to stelleg/Tapir-LLVM that referenced this issue Dec 20, 2018
@neboat @stelleg
[Tapir] Handle structure-return parameters correctly in outlined help…
40de636 
…er functions. This commit addresses issue wsmoses#38.
stelleg pushed a commit to stelleg/Tapir-LLVM that referenced this issue Jan 12, 2019
@neboat @stelleg
[Tapir] Handle structure-return parameters correctly in outlined help…
2318c5f 
…er functions. This commit addresses issue wsmoses#38.
stelleg pushed a commit to stelleg/Tapir-LLVM that referenced this issue Mar 14, 2019
@neboat @stelleg
[Tapir] Handle structure-return parameters correctly in outlined help…
f168337 
…er functions. This commit addresses issue wsmoses#38.
stelleg pushed a commit to stelleg/Tapir-LLVM that referenced this issue May 9, 2019
@neboat @stelleg
[Tapir] Handle structure-return parameters correctly in outlined help…
e7a7e22 
…er functions. This commit addresses issue wsmoses#38.
stelleg pushed a commit to stelleg/Tapir-LLVM that referenced this issue May 17, 2019
@neboat @stelleg
[Tapir] Handle structure-return parameters correctly in outlined help…
76aa674 
…er functions. This commit addresses issue wsmoses#38.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neboat @timkaler