Bugfixes 20180207 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…outlined helper functions, since these helper functions return void.
…e when outlining a Tapir helper function.
…ed to eliminate a recursive tail.
…resulting IR is technically valid, but it seems hard for MachineCodeGen to produce appropriate machine code for this IR, e.g., for X86, where results of comparisons are stored in EFLAGS.
…t a conditional branch.
wsmoses
approved these changes
Feb 8, 2018
| // Disallow hoisting of setjmp. Although hoisting the setjmp technically | ||
| // produces valid IR, it seems hard to generate appropariate machine code | ||
| // from this IR, e.g., for X86. | ||
| if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(I1)) |
There was a problem hiding this comment.
We should potentially leave an open issue with this as a reminder to return to it later.
There was a problem hiding this comment.
Sure, feel free to create it. I've talked to Charles about this bug, and we have ideas for a more precise fix, but the implementation would be substantially more elaborate. Our current thinking is to save the project of implementing the precise fix for another student.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits include several bug fixes from other branches, along with regression tests for those bug fixes. Some of these regression tests also test the
-tapir-targetopt flag.